Who should merge a pull request, author or reviewer?

Navigation
0

Scenery:

  • Author submits a pull request.
  • Reviewer examines the code.
    • Approve and leave a comment: "It was very good!".
    • Find points that can be improved or corrected and returned to the author.
  • The author makes the necessary changes and then merges the PR.

    • Considerations:

    • Once we have the approved PR (item 3), the reviewer could immediately merge, instead of requesting the author.

    Who is better able to perform the merge? What is more common in development teams today?

        
    asked by anonymous 23.02.2018 / 17:01

    0 answers

    Failed with PostAsJsonAsync - WebApi - C # Automatic Facebook posts lost images