Carrierwave - destroy object only after it has been deleted from my storage

What I did was call remove_avatar! before calling super() and actually doing the removal, without changing anything in the callbacks.

For registration, follow the code of concern:

# BackgroundDestroyable classes MUST have deleted_at:datetime column
module BackgroundDestroyable
  extend ActiveSupport::Concern

  included do
    default_scope { where(deleted_at: nil) }
    scope :deleted, -> { unscoped.where.not(deleted_at: nil) }
  end

  def destroy(mode = :background)
    if mode == :background
      unless self.deleted_at.present?
        update_attribute :deleted_at, Time.now
        Resque.enqueue(BackgroundDestroyer, self.id, self.class.to_s)
      end
    elsif mode == :now
      self.class.uploaders.each do |uploader, uploader_class|
        self.send("remove_#{uploader}!")
      end
      super()
    end
  end

  def destroy_now!
    self.destroy(:now)
  end
end

For me, it makes more sense to call remove_avatar! before calling object.destroy . So you always have the assurance that you will not have any orphaned objects in S3, checking to see if the object has actually been removed.

I'd rather not mess with callbacks, unless I know exactly what I'm doing. Also, I always prefer to leave explicit behavior in the code and callbacks are not very explicit. And from experience, you will thank yourself very much in a couple of months when you need to look at this script and do some maintenance on it.