How could I reduce this code?

Question

How could I reduce this code?

Navigation

#1 by (1 votes)

-3

def hello_quantum(string):
    """
    hello_quantum: cad. caracteres --> lógico
    funcao permite jogar o jogo praticamente, permite o uso das portas para manipular o tabuleiro
    com o objetivo de igualar o tabuleiro inicial ao tabuleiro introduzido

    """
    a = eval(string.replace(":",",")) # transforma o string num tuplo, onde primeiro elemento eh o tabuleiro,
                                                                    #  e segundo eh o numero jogadas maximas
    num_jogadas = a[1]
    t_objetivo = str_para_tabuleiro(str(a[0]))
    counter = 0
    t_inicial = tabuleiro_inicial()
    tabu = []

    print("Bem-vindo ao Hello Quantum!\nO seu objetivo e chegar ao tabuleiro:")
    print(tabuleiro_para_str(t_objetivo))
    print("Comecando com o tabuleiro que se segue:")
    print(tabuleiro_para_str(t_inicial))


    while num_jogadas > counter and not (t_objetivo == tabu):
        in_porta = input("Escolha uma porta para aplicar (X, Z ou H): ")

        in_lado = input("Escolha um qubit para analisar (E ou D): ")

        if in_porta == "X":
            if in_lado == "E":
                tabu = porta_x(t_inicial,"E")
            else:
                tabu = porta_x(t_inicial,"D")
            print(tabuleiro_para_str(tabu))

        elif in_porta == "Z":
            if in_lado == "E":
                tabu = porta_z(t_inicial,"E")
            else:
                tabu = porta_z(t_inicial,"D")
            print(tabuleiro_para_str((tabu)))

        elif in_porta == "H":
            if in_lado == "E":
                tabu = porta_h(t_inicial,"E")
            else:
                tabu = porta_h(t_inicial,"D")
            print(tabuleiro_para_str(tabu))

        counter += 1

    if tabuleiros_iguais(tabu,t_objetivo):
        print("Parabens, conseguiu converter o tabuleiro em %s jogadas!"%(counter))
        return True

    else:
        return False

Function made with data abstraction, so it calls various other functions.

python python-requests

asked by anonymous 06.12.2018 / 18:07

1 answer

What is required to create an authentication system (login / password / session) in PHP? What important points should I be concerned about? [duplicate] Working with arrays [closed]

score 1 · Answer 1

@ user133264, your question is vague when you ask how to reduce the code. Because reducing can mean doing less lines, reducing processing time, reducing number of loops (which ends up relating to the last two points), etc.

But I'm assuming reduce how to make a leaner code.

First point is that you do not detail the other functions being called, but something that would already reduce the amount of code absurdly, would be:
1. add a dictionary to map the relationship between in_portas and functions
2. Check if in_lado and in_portas received a valid value
3. change all if , elif and else by a single line of code:

portas = {
            'X': porta_x, 
            'H': porta_h,
            'Z': porta_z
        }
lados = ["E", "D"]

if in_porta not in portas or in_lado not in lados:
     continue

tabu = portas[in_porta](t_inicial,in_lado)

I believe that here you already have a great gain of the inefficiency of loops that had created. When to the rest of the code, I would need more details of the functions to make it even more efficient, but it seems to me that you were looking for something to optimize the loops themselves (if not, let me know)