Is there any way to reduce if's in my code?

Question

Is there any way to reduce if's in my code?

Navigation

#1 by (2 votes)

-3

function updateUser($usuario, $senha, $adm){
    //Atualiza informações sobre o usuário
    $sql_query; 
    $q_senha = ""; 
    $q_adm = "";
    $dot = "";
    if(!empty($senha)){
        $q_senha = "senha=md5('$senha')";
    }
    if($adm != NULL){
        $q_adm = "adm='$adm'";
    }
    if($adm != NULL and !empty($senha)){
        $dot = ",";
    }
    $sql_query = "update tb_users set ".$q_senha.$dot." ".$q_adm." where usuario='$usuario';";
    return $this->execute($sql_query);
}

I know it's a simple situation and from what I've read the Strategy is an efficient way for cases with many if's, and that's not my case. But I do believe it has some way of reducing through a good use of SQL. But I did not find anything on the internet about it.

php sql

asked by anonymous 21.08.2018 / 14:43

1 answer

Display messages from a list sequentially Is it possible to check if two variables are defined in an easier way?

score 2 · Accepted Answer

You have how to use ternary operator, follow the example:

function updateUser($usuario, $senha, $adm){
    //Atualiza informações sobre o usuário
    $q_senha = (!empty($senha)) ? "senha=md5('$senha')" : "";
    $q_adm = ($adm != NULL) ? "adm='$adm'" : "";
    $dot = ($adm != NULL and !empty($senha)) ? "," : "";

    $sql_query = "update tb_users set ".$q_senha.$dot." ".$q_adm." where usuario='$usuario';";
    return $this->execute($sql_query);
}

You can read more about the ternary operator here .